Yes, this solved the problem. Thank you... Will
On Mon, Dec 9, 2013 at 3:56 AM, Sebastien Goasguen <run...@gmail.com> wrote: > Will, > > Did that solve your problem ? > > On Dec 7, 2013, at 3:15 AM, Girish Shilamkar <gir...@clogeny.com> wrote: > > > Fixed in 4.2, 4.3 and master. > > > > Regards, > > Girish > > > > On 07-Dec-2013, at 12:47 PM, Girish Shilamkar <gir...@clogeny.com> > wrote: > > > >> Mea culpa. I will push the missed out files. > >> > >> Regards, > >> Girish > >> > >> On 07-Dec-2013, at 12:34 PM, Santhosh Edukulla < > santhosh.eduku...@citrix.com> wrote: > >> > >>> I was thinking that it was an install issue. So, I just pulled the > latest code for 4.3 and master to see the changes for this patch, i could > see marvinLog.py and marvinInit.py files seems to be missing and so is the > reason for this failure. If we see, these files were available as part of > the patch, these were not pushed. > >>> > >>> Regards, > >>> Santhosh > >>> ________________________________________ > >>> From: williamstev...@gmail.com [williamstev...@gmail.com] on behalf > of Will Stevens [wstev...@cloudops.com] > >>> Sent: Saturday, December 07, 2013 12:24 AM > >>> To: Santhosh Edukulla > >>> Cc: dev@cloudstack.apache.org; Girish Shilamkar > >>> Subject: Re: Review Request 15922: Enhanced few features under Marvin > >>> > >>> If you looked at the steps I have done, you will see that I have done > that... > >>> > >>> I have done a clean install in order to get the latest marvin. That > didnt work so I tried grabbing a version from online. That didnt work. I > also tried doing a 'python setup.py install'. That also didn't work... > >>> > >>> So you're saying that this SHOULD work??? > >>> > >>> > >>> # clean install (I have to skip tests because 'Apache CloudStack > Console Proxy - RDP Client' fails tests) > >>> $ mvn -P developer,systemvm clean install -Dmaven.test.skip=true > >>> > >>> # deploy the db > >>> $ mvn -P developer -pl developer,tools/devcloud -Ddeploydb > >>> > >>> # I have done it with and without the following lines > >>> $ cd tools/marvin > >>> $ python setup.py install > >>> > >>> # start the server > >>> $ chmod 755 > /mnt/hgfs/palo_alto/cloudstack/client/target/cloud-client-ui-4.3.0-SNAPSHOT/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh > >>> $ export MAVEN_OPTS="-Xmx1024m -XX:MaxPermSize=512m -Xdebug > -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n" > >>> $ mvn -pl :cloud-client-ui jetty:run > >>> > >>> # now I try to deploy the server > >>> $ export MAVEN_OPTS="" > >>> $ mvn -P developer -pl tools/devcloud -Ddeploysvr -X > >>> > >>> This results in: > >>> > >>> [DEBUG] Executing command line: python > ../marvin/marvin/deployDataCenter.py -i devcloud.cfg > >>> Traceback (most recent call last): > >>> File "../marvin/marvin/deployDataCenter.py", line 567, in <module> > >>> from marvin.marvinLog import MarvinLog > >>> ImportError: No module named marvinLog > >>> > >>> > >>> On Fri, Dec 6, 2013 at 11:32 PM, Santhosh Edukulla < > santhosh.eduku...@citrix.com<mailto:santhosh.eduku...@citrix.com>> wrote: > >>> 1. The path mentioned below does not contain latest. > >>> > >>> 2. When you pull the latest 4.3 code, the latest marvin for that > build is available with it. So, running python setup.py install in that > folder should install latest marvin > >>> > >>> 3. In your case of running mvn, under devcloud pom.xml, you are asking > it to run deploy data center as well using "-Ddeploysvr" switch which > requires latest marvin to work with deployDataCenter. > >>> > >>> So for devcloud module, you need latest marvin. I would recommend > running "mvn clean install" or with other some profile as "mvn clean > install -P developer,systemvm" It will get you latest marvin with > cloudstackAPI folder and running > >>> python setup.py install from tools/marvin should install the marvin. > >>> > >>> Thereafter you can build devcloud. Let me know. > >>> > >>> > >>> Regards, > >>> Santhosh > >>> ________________________________________ > >>> From: williamstev...@gmail.com<mailto:williamstev...@gmail.com> [ > williamstev...@gmail.com<mailto:williamstev...@gmail.com>] on behalf of > Will Stevens [wstev...@cloudops.com<mailto:wstev...@cloudops.com>] > >>> Sent: Friday, December 06, 2013 10:59 PM > >>> To: Santhosh Edukulla > >>> Cc: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>; > Girish Shilamkar > >>> Subject: Re: Review Request 15922: Enhanced few features under Marvin > >>> > >>> Where do I get the latest package? I was getting 1555 from here: > https://builds.apache.org/job/cloudstack-marvin/ > >>> > >>> I did run 'python setup.py install' in the 'tools/marvin' directory > and that did not work either. > >>> > >>> Can you specify the steps I need to take to get this working? > >>> > >>> Thanks, > >>> > >>> Will > >>> > >>> > >>> On Fri, Dec 6, 2013 at 10:55 PM, Santhosh Edukulla < > santhosh.eduku...@citrix.com<mailto:santhosh.eduku...@citrix.com><mailto: > santhosh.eduku...@citrix.com<mailto:santhosh.eduku...@citrix.com>>> wrote: > >>> Hi will, > >>> > >>> You need to install latest marvin. Changes to it requires for users to > install it again. Using mvn, it just builds and packages, it wont install. > >>> > >>> under marvin folder, run python setup.py install, or can use pip > install marvin..tar.gz > >>> > >>> Thanks! > >>> Santhosh > >>> ________________________________________ > >>> From: Will Stevens [nore...@reviews.apache.org<mailto: > nore...@reviews.apache.org><mailto:nore...@reviews.apache.org<mailto: > nore...@reviews.apache.org>>] on behalf of Will Stevens [ > wstev...@cloudops.com<mailto:wstev...@cloudops.com><mailto: > wstev...@cloudops.com<mailto:wstev...@cloudops.com>>] > >>> Sent: Friday, December 06, 2013 4:14 PM > >>> To: Girish Shilamkar > >>> Cc: Santhosh Edukulla; Will Stevens; cloudstack > >>> Subject: Re: Review Request 15922: Enhanced few features under Marvin > >>> > >>>> On Dec. 6, 2013, 6:35 a.m., Girish Shilamkar wrote: > >>>>> Committed to 4.2, 4.3 and master. > >>> > >>> I am unable to run the following command on the 4.3 branch now: > >>> > >>> mvn -P developer -pl tools/devcloud -Ddeploysvr -X > >>> > >>> I get one of the following error: > >>> [DEBUG] Executing command line: python > ../marvin/marvin/deployDataCenter.py -i devcloud.cfg > >>> Traceback (most recent call last): > >>> File "../marvin/marvin/deployDataCenter.py", line 567, in <module> > >>> from marvin.marvinLog import MarvinLog > >>> ImportError: No module named marvinLog > >>> > >>> or > >>> > >>> [DEBUG] Executing command line: python > ../marvin/marvin/deployDataCenter.py -i devcloud.cfg > >>> Traceback (most recent call last): > >>> File "../marvin/marvin/deployDataCenter.py", line 19, in <module> > >>> import configGenerator > >>> File > "/mnt/hgfs/palo_alto/cloudstack/tools/marvin/marvin/configGenerator.py", > line 22, in <module> > >>> from marvin.codes import * > >>> ImportError: No module named codes > >>> > >>> > >>> I have rebuilt my system many times now trying to get this to work. > >>> > >>> Partially related to this process. In order to use devcloud I had to > make the following changes to the root pom.xml > >>> $ git diff pom.xml > >>> diff --git a/pom.xml b/pom.xml > >>> index 31946d8..a49927e 100644 > >>> --- a/pom.xml > >>> +++ b/pom.xml > >>> @@ -747,9 +747,7 @@ > >>> </properties> > >>> <modules> > >>> <module>developer</module> > >>> - <!-- > >>> <module>tools</module> > >>> ---> > >>> </modules> > >>> </profile> > >>> <profile> > >>> @@ -759,7 +757,7 @@ > >>> </properties> > >>> <modules> > >>> <module>developer</module> > >>> - <!--module>tools/devcloud</module --> > >>> + <module>tools/devcloud</module> > >>> </modules> > >>> </profile> > >>> <profile> > >>> > >>> > >>> Also, because my code is in a shared directory, I have to also make > this change: > >>> $ git diff tools/marvin/pom.xml > >>> diff --git a/tools/marvin/pom.xml b/tools/marvin/pom.xml > >>> index 0869248..f33fedf 100644 > >>> --- a/tools/marvin/pom.xml > >>> +++ b/tools/marvin/pom.xml > >>> @@ -73,7 +73,7 @@ > >>> <executable>python</executable> > >>> <arguments> > >>> <argument>setup.py</argument> > >>> - <argument>sdist</argument> > >>> + <argument>install</argument> > >>> </arguments> > >>> </configuration> > >>> </execution> > >>> @@ -126,7 +126,7 @@ > >>> <executable>python</executable> > >>> <arguments> > >>> <argument>setup.py</argument> > >>> - <argument>sdist</argument> > >>> + <argument>install</argument> > >>> </arguments> > >>> </configuration> > >>> </execution> > >>> > >>> > >>> Here are my steps for trying to rebuild my environment: > >>> > >>> # completely blow away and rebuild my DB > >>> $ /etc/init.d/mysqld stop > >>> $ rm -rf /var/lib/mysql/ > >>> $ /etc/init.d/mysqld start > >>> > >>> # clean install (I have to skip tests because 'Apache CloudStack > Console Proxy - RDP Client' fails tests) > >>> $ mvn -P developer,systemvm clean install -Dmaven.test.skip=true > >>> > >>> # deploy the db > >>> $ mvn -P developer -pl developer,tools/devcloud -Ddeploydb > >>> > >>> # start the server > >>> $ chmod 755 > /mnt/hgfs/palo_alto/cloudstack/client/target/cloud-client-ui-4.3.0-SNAPSHOT/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh > >>> $ export MAVEN_OPTS="-Xmx1024m -XX:MaxPermSize=512m -Xdebug > -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n" > >>> $ mvn -pl :cloud-client-ui jetty:run > >>> > >>> # once the server is started I resync marvin > >>> $ cd tools/marvin/dist/ > >>> $ curl -o Marvin-0.1.0.tar.gz > https://builds.apache.org/job/cloudstack-marvin/lastSuccessfulBuild/artifact/tools/marvin/dist/Marvin-0.1.0-1555.tar.gz > >>> $ export MAVEN_OPTS="" > >>> $ mvn -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin > >>> > >>> # now I try to deploy the server > >>> $ export MAVEN_OPTS="" > >>> $ mvn -P developer -pl tools/devcloud -Ddeploysvr -X > >>> > >>> # I have tried running 'python setup.py install' inside 'tools/marvin' > as well as many other combinations of steps. > >>> > >>> I have spent a solid half day trying to troubleshoot this... > >>> > >>> > >>> - Will > >>> > >>> > >>> ----------------------------------------------------------- > >>> This is an automatically generated e-mail. To reply, visit: > >>> https://reviews.apache.org/r/15922/#review29875 > >>> ----------------------------------------------------------- > >>> > >>> > >>> On Nov. 30, 2013, 6:27 p.m., Santhosh Edukulla wrote: > >>>> > >>>> ----------------------------------------------------------- > >>>> This is an automatically generated e-mail. To reply, visit: > >>>> https://reviews.apache.org/r/15922/ > >>>> ----------------------------------------------------------- > >>>> > >>>> (Updated Nov. 30, 2013, 6:27 p.m.) > >>>> > >>>> > >>>> Review request for cloudstack and Girish Shilamkar. > >>>> > >>>> > >>>> Repository: cloudstack-git > >>>> > >>>> > >>>> Description > >>>> ------- > >>>> > >>>> Added few enhancements to marvin. > >>>> Added new module for Logging Facility to marvin. > >>>> Added new Init facility to marvin. > >>>> Currently, there are multiple ways we are doing logging > >>>> Removed few unwanted logging cases. > >>>> Removed few command line switch options for logging. > >>>> The new way of logging now provides consolidated logging > >>>> under one single folder timestamped under the configured > >>>> folder path. > >>>> Removed parsing configuration from deploydata center > >>>> Added parsing,start logging and deploy as part of init > >>>> Added new error handling facility to catch unknown exception from > >>>> test cases. Currently, lot of scripts are throwing unknown > >>>> exceptions, add a handler to plugin to dump them to a file > >>>> > >>>> ToDO: > >>>> Will do clean up in phase2 for this patch. > >>>> Separate deployDatacenter from creating test client. > >>>> Clean up configGenerator > >>>> > >>>> > >>>> Diffs > >>>> ----- > >>>> > >>>> setup/dev/advanced.cfg 216314f > >>>> tools/marvin/marvin/cloudstackConnection.py 23f81fb > >>>> tools/marvin/marvin/codes.py f409c7c > >>>> tools/marvin/marvin/configGenerator.py 631e40f > >>>> tools/marvin/marvin/deployDataCenter.py 3f7eebb > >>>> tools/marvin/marvin/marvinInit.py PRE-CREATION > >>>> tools/marvin/marvin/marvinLog.py PRE-CREATION > >>>> tools/marvin/marvin/marvinPlugin.py 0e52bab > >>>> > >>>> Diff: https://reviews.apache.org/r/15922/diff/ > >>>> > >>>> > >>>> Testing > >>>> ------- > >>>> > >>>> Tested locally. Ran smoke tests. As well, run deploydatacenter > separately to check deployement is working fine. > >>>> > >>>> > >>>> Thanks, > >>>> > >>>> Santhosh Edukulla > >>>> > >>>> > >>> > >>> > >> > > > >
