> On Dec. 9, 2013, 6:03 p.m., Nitin Mehta wrote: > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, > > line 3007 > > <https://reviews.apache.org/r/16122/diff/2/?file=395664#file395664line3007> > > > > Why are you reserving if the flag is false ?
Hi Nitin, this patch is not related to the https://reviews.apache.org/r/15349/. will upload it once this gets shipped. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16122/#review30027 ----------------------------------------------------------- On Dec. 9, 2013, 10:39 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16122/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2013, 10:39 a.m.) > > > Review request for cloudstack and Jayapal Reddy. > > > Bugs: CLOUDSTACK-4498 > https://issues.apache.org/jira/browse/CLOUDSTACK-4498 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the > vmware.reserve.cpu and vmware.reserve.mem are set to false. > > > Diffs > ----- > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > eb3cb6b > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > d306b74 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 69f1b74 > > Diff: https://reviews.apache.org/r/16122/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
