----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16122/#review30183 -----------------------------------------------------------
Ship it! Ship It! - Jayapal Reddy On Dec. 11, 2013, 5:45 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16122/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 5:45 a.m.) > > > Review request for cloudstack and Jayapal Reddy. > > > Bugs: CLOUDSTACK-4498 > https://issues.apache.org/jira/browse/CLOUDSTACK-4498 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the > vmware.reserve.cpu and vmware.reserve.mem are set to false. > > > Diffs > ----- > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 081c651 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 066a395 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > e34d5e1 > > Diff: https://reviews.apache.org/r/16122/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
