----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16178/#review30203 -----------------------------------------------------------
test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57820> Are we ok to raise for one deletion failure? we have other entities below for deletion. test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57819> Just verify the order of deletion. nwofferings or domain? test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57817> Please follow proper spacing and lining test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57818> clean up with new way of list assertion test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57815> There is no clean up i believe in case of an exception? tools/marvin/marvin/integration/lib/common.py <https://reviews.apache.org/r/16178/#comment57814> Whats the significance of this loop? We are not taking any action based upon some matched\unmatched condition here. We are either continuing or breaking but no action as what to do. Little unclear here. - Santhosh Edukulla On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16178/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 8:30 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-2237 > https://issues.apache.org/jira/browse/CLOUDSTACK-2237 > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation tests for feature "Security Group Isolation in advanced > zone". > > @Santhosh: Please check the change in configGenerator file. Made changes to > take relative path. > > > Diffs > ----- > > test/integration/component/test_advancedsg_networks.py 4834351 > tools/marvin/marvin/config/config.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 6d5b70d > tools/marvin/marvin/integration/lib/base.py 86f962a > tools/marvin/marvin/integration/lib/common.py 096b073 > > Diff: https://reviews.apache.org/r/16178/diff/ > > > Testing > ------- > > Tested locally on Advanced zone setup with security group enabled. > > > Thanks, > > Ashutosh Kelkar > >
