> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_advancedsg_networks.py, line 1702 > > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1702> > > > > There is no clean up i believe in case of an exception?
The important operations in test cases (Exactly what we are trying to test) such as shared network creation, vm creation are covered under try block and test cases are failed if exception is raised, but simpler operation like account creation do not need it IMO. In that case, we can cover whole test case under try block. What do you suggest? - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16178/#review30203 ----------------------------------------------------------- On Dec. 16, 2013, 9:45 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16178/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 9:45 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-2237 > https://issues.apache.org/jira/browse/CLOUDSTACK-2237 > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation tests for feature "Security Group Isolation in advanced > zone". > > @Santhosh: Please check the change in configGenerator file. Made changes to > take relative path. > > > Diffs > ----- > > test/integration/component/test_advancedsg_networks.py 4834351 > tools/marvin/marvin/config/config.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 6d5b70d > tools/marvin/marvin/integration/lib/base.py b43af33 > tools/marvin/marvin/integration/lib/common.py 096b073 > > Diff: https://reviews.apache.org/r/16178/diff/ > > > Testing > ------- > > Tested locally on Advanced zone setup with security group enabled. > > > Thanks, > > Ashutosh Kelkar > >
