> On Jan. 21, 2014, 10:22 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_remotevpn_vpc.py, line 432 > > <https://reviews.apache.org/r/16867/diff/1/?file=424901#file424901line432> > > > > is %d right here?
%defaultroute is specific to ipsec.conf file. It is not %d implying int. Dropping the issue based on this reason. Kindly reopen it in case if more explanation is required. > On Jan. 21, 2014, 10:22 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_remotevpn_vpc.py, line 447 > > <https://reviews.apache.org/r/16867/diff/1/?file=424901#file424901line447> > > > > why some static methods and few class methods? I used static methods for the operations where i have to just create a file and obtain the file. It doesn't have to know anything about the class or instance it was called on. It just gets the arguments that were passed, no implicit first argument. Dropping the issue based on this reason. Kindly reopen it in case if more explanation is required. - Chandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16867/#review32353 ----------------------------------------------------------- On Jan. 16, 2014, 7:12 p.m., Chandan Purushothama wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16867/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 7:12 p.m.) > > > Review request for cloudstack, Girish Shilamkar, SrikanteswaraRao Talluri, > and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Test Suite for Testing Remote Access VPN on VPC. > > I successfully automated the following components: > > 1.VPN Client Installation on Linux > 2.Component that efficiently verifies Remote VPN Access between client and > the Server. > 3.Developed a component that automates VPN Client Configuration and services. > 4.Test Cases of the Feature > 5.Tested the Code multiple times on XenServer and fixed the bugs. > 6.Requirement on VMWare: Default Template should be CentOS 5.5 or higher for > the test suite to work. VPN Client cannot be installed on CentOS 5.3 Default > Template on VMWare. > > > Diffs > ----- > > test/integration/component/test_remotevpn_vpc.py PRE-CREATION > > Diff: https://reviews.apache.org/r/16867/diff/ > > > Testing > ------- > > Test case no : Enable VPN for Public IP Address on the VPC ... ok > Test case no : Remote a VPN User ... ok > Test case no : Add a Different VPN User and Test Access with already existing > VPN User ... ok > Test case no : Add a Previously Removed VPN User from the VPC and Test the > VPN Connectivity ... ok > Test case no : Disable the VPN Service on the VPC ... ok > Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... ok > Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 > Configuration parameter ... ok > > ---------------------------------------------------------------------- > Ran 7 tests in 645.787s > > OK > > > File Attachments > ---------------- > > 0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch > > https://reviews.apache.org/media/uploaded/files/2014/01/14/c6d3f593-d0eb-407c-aad2-574ebf9ca0f8__0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch > > > Thanks, > > Chandan Purushothama > >
