----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16867/#review32596 -----------------------------------------------------------
test/integration/component/test_remotevpn_vpc.py <https://reviews.apache.org/r/16867/#comment61502> This is still not unconvincing as test script connecting over wire to download few packages to get it working. We are not sure of network connectivity issues, package mirrors not working, has an issue etc. After few months of this script, issues could arise and we dont have checks to see what to do in case of this download failed. We are assuming that the installation went fine. You can assume one standard template for regression now and use those default packages. Time factor is one of those issues, other issues may still arise. Also wrap this under try\except block. test/integration/component/test_remotevpn_vpc.py <https://reviews.apache.org/r/16867/#comment61507> I still believe providing them external to test suite enhances readability, maintainability, less overhead in suite. Even now as well, the test script owner still has to alter the code here to get his desired configuration as such the script is hard coded here? If the intention is to alter the script content for fine tuning the vpn client, he can still do it by reading through the file and altering the contents and storing back. Currently, there is no provision provided for editing the configuration through args\config, instead he has to alter the suite code directly. We can move to external files for now. test/integration/component/test_remotevpn_vpc.py <https://reviews.apache.org/r/16867/#comment61508> Also, many methods are provided to write the content to file, as mentioned in one of the comment move these content external to test code, if we still wanted to provide an option of writing to a file. 1 ) Provide one interface for writing content to a file by providing test file name, content to write and mode, rather multiple methods. 2) Move this as a library method under utils etc. test/integration/component/test_remotevpn_vpc.py <https://reviews.apache.org/r/16867/#comment61504> ok, it mentions to add the below, look for line "and simply place at the end the special parameter $@". Also, will it work for all shells, dont we need to source anything before execution for this behavior to work? I believe its better to call based upon cmd line arguments for safer side. - Santhosh Edukulla On Jan. 16, 2014, 7:12 p.m., Chandan Purushothama wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16867/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 7:12 p.m.) > > > Review request for cloudstack, Girish Shilamkar, SrikanteswaraRao Talluri, > and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Test Suite for Testing Remote Access VPN on VPC. > > I successfully automated the following components: > > 1.VPN Client Installation on Linux > 2.Component that efficiently verifies Remote VPN Access between client and > the Server. > 3.Developed a component that automates VPN Client Configuration and services. > 4.Test Cases of the Feature > 5.Tested the Code multiple times on XenServer and fixed the bugs. > 6.Requirement on VMWare: Default Template should be CentOS 5.5 or higher for > the test suite to work. VPN Client cannot be installed on CentOS 5.3 Default > Template on VMWare. > > > Diffs > ----- > > test/integration/component/test_remotevpn_vpc.py PRE-CREATION > > Diff: https://reviews.apache.org/r/16867/diff/ > > > Testing > ------- > > Test case no : Enable VPN for Public IP Address on the VPC ... ok > Test case no : Remote a VPN User ... ok > Test case no : Add a Different VPN User and Test Access with already existing > VPN User ... ok > Test case no : Add a Previously Removed VPN User from the VPC and Test the > VPN Connectivity ... ok > Test case no : Disable the VPN Service on the VPC ... ok > Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... ok > Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 > Configuration parameter ... ok > > ---------------------------------------------------------------------- > Ran 7 tests in 645.787s > > OK > > > File Attachments > ---------------- > > 0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch > > https://reviews.apache.org/media/uploaded/files/2014/01/14/c6d3f593-d0eb-407c-aad2-574ebf9ca0f8__0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch > > > Thanks, > > Chandan Purushothama > >
