1. code restructuring ,definitely yes, it makes little neat and plugin does not worry much about deploy altogether. Take an example of load option, it is little redundant i believe, if user passes the deploy flag, deploy should work and continue, if not passed should be treated as work with loading provided configuration and continue with no deploy. Even, for redeploying, user can still use deployDC, we don't exit cleanly in a way if deployDC has an issue. The main reason behind this is providing some fine tuner logging for test modules not worrying about the logs when deployDC runs as part of marvinplugin. I have seen people currently run individual test suites post deployDC separately. Is there a case explicitly for redploying with same configuration and i believe if so it breaks, if its a new cofiguration then its a new deploy altogether. To make plugin init, start cleaner this makes to remove. Tying nosetests plugin to few things other than tests is also little confusing.
2. Exporting a datacenter option would be an idea i believe best fits for cloudstack, this i have raised in a mail thread earlier, where user can export or import configuration for a datacenter. So, that once exported can tweak few parameters and reimport. This will help create second datacenter with similar configuration easy and store his existing configuration as well, it will help other areas of automation as well. 3. Not sure, why we need to use marvinplugin for simulator deployDC? we can still use deployDC and run tests against the similator. Currently, also i have seen we use unittest load and run as part of mvn profile for simulator. Any places where marvinplugin is used for simulator? For devcloud, do we run nosetests using marvinplugin or run deployDC separately, if its a case we can remove there as well. Regards, Santhosh ________________________________________ From: Prasanna Santhanam [t...@apache.org] Sent: Friday, February 07, 2014 1:54 AM To: dev@cloudstack.apache.org Subject: Re: Removing deploy\load options from marvinplugin On Fri, Feb 07, 2014 at 06:44:07AM +0000, Santhosh Edukulla wrote: > Team, > > Do we have any issues if we remove dpeloy\load options from > marvinPlugin? Iam assuming users wanted to use deployDC can still > use other options available i.e.., deployDC etc. > > So, we just use marvinplugin to run only tests either list of suites > or individual suites? Let me know. > > EX: > 1. nosetests-2.7 -v --with-marvin > --marvin-config=/root/softwares/cscode/setup/dev/advanced.cfg -w > /tmp/checkfew/ -a tags=advanced :: Here, no load\deploy option. We > just use the config provided and run suites under the provided > directory. > > 2. nosetests-2.7 -v --with-marvin > --marvin-config=/root/softwares/cscode/setup/dev/advanced.cfg > /tmp/checkfew/test_x.py -a tags=advanced ::: Here, no load\deploy > option, we just use the config provided and run one single suite. > It's nice to have the ability to deploy and re-deploy the datacenter. In fact, it would be nicer to extended the deployer to also export the entire deployment model into json format. That way I can feed back the exported JSON and repeat my tests on a new deployment. What would happen to the deployer if marvin can only run test suites? This will potentially break few nice parts like - working on devcloud with a choice of configuration, work with the simulator as well. Any motivation besides code restructuring? -- Prasanna., ------------------------ Powered by BigRock.com
