----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17888/ -----------------------------------------------------------
(Updated Feb. 11, 2014, 2:44 p.m.) Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo Trippaers. Changes ------- Adding Alena to reviewers since she found the previous bug that I introduced in my previous commit and I would appreciate her help finding out if this should give any other problem Repository: cloudstack-git Description ------- Dispatcher corrections, refactoring and tests. Corrects problems from previous attempts that were reverted by Alena. Most of the changes are the same, but this one is not creating conflicts of Map types for Aync Commands or for parameters as Lists or Maps. Diffs ----- api/src/org/apache/cloudstack/api/ApiConstants.java d500303 api/src/org/apache/cloudstack/api/BaseCmd.java 0e83cee api/src/org/apache/cloudstack/api/BaseListCmd.java c1a4b4c api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmProfileCmd.java bee1b22 server/resources/META-INF/cloudstack/core/spring-server-core-misc-context.xml fd2f5fb server/src/com/cloud/api/ApiAsyncJobDispatcher.java 71ac616 server/src/com/cloud/api/ApiDispatcher.java ed95c72 server/src/com/cloud/api/ApiServer.java d715db6 server/src/com/cloud/api/ApiServlet.java 46f7eba server/src/com/cloud/api/dispatch/CommandCreationWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchChain.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchChainFactory.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchTask.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamProcessWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamSemanticValidationWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamUnpackWorker.java PRE-CREATION server/src/com/cloud/network/as/AutoScaleManagerImpl.java 21c38ce server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java 3159059 server/test/com/cloud/api/ApiDispatcherTest.java 7314a57 server/test/com/cloud/api/dispatch/CommandCreationWorkerTest.java PRE-CREATION server/test/com/cloud/api/dispatch/DispatchChainFactoryTest.java PRE-CREATION server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java PRE-CREATION server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java PRE-CREATION server/test/com/cloud/api/dispatch/ParamSemanticValidationWorkerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17888/diff/ Testing ------- Full build and test plus manually testing many features. Also including CreateTagsCommand that failed in previous commit. Thanks, Antonio Fornie
