> On March 24, 2014, 3:01 p.m., Sebastien Goasguen wrote:
> > I applied it to master (future 4.5) 
> > 
> > d5333f4596460c7123b66ad5c19fc69442696ea2
> > 
> > and 4.4 branch.
> > Please test these new branches from source as I did not have time to test 
> > it.
> > 
> > thanks a lot for the patch

Dmitry, can you add the apache license headers and remove the @author tags.

if you do it today, I will apply asap to avoid breaking the license checker.

thanks, I should have caught that.


- Sebastien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/#review38297
-----------------------------------------------------------


On March 24, 2014, 2:50 p.m., Dmitry Batkovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 2:50 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> * CloudStackClient.java http request mechanism replaced from GET requests to 
> POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea 
>   awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 
>   awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION 
>   awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 
>   awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17586/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Batkovich
> 
>

Reply via email to