----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17586/#review41135 -----------------------------------------------------------
it seems awsapi/src/com/cloud/stack/CloudStackClientException.java is in this patch twice!?! Can you check the patch? awsapi/src/com/cloud/bridge/util/JsonElementUtil.java <https://reviews.apache.org/r/17586/#comment74549> license header needed awsapi/src/com/cloud/stack/CloudStackClientException.java <https://reviews.apache.org/r/17586/#comment74550> license header needed awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java <https://reviews.apache.org/r/17586/#comment74551> please apply the coding conventions (no tabs) awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java <https://reviews.apache.org/r/17586/#comment74552> please apply the coding conventions (no trailing spaces) - daan Hoogland On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17586/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:50 p.m.) > > > Review request for cloudstack, daan Hoogland and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > * CloudStackClient.java http request mechanism replaced from GET requests to > POST for supporting EC2 requests larger than 2KB > * SSL enabling fixed in EC2Engine.java > > > Diffs > ----- > > awsapi/conf/ec2-service.properties.in 82f5ad8 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 > awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5 > awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 > awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 > awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION > awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef > awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 > awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION > awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a > awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 > awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17586/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > cloudstack_api_post_and_ssl_fix.patch > > https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch > > > Thanks, > > Dmitry Batkovich > >
