----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47289 -----------------------------------------------------------
I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch. - Hugo Trippaers On July 3, 2014, 10:22 a.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23192/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 10:22 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 > > > Repository: cloudstack-git > > > Description > ------- > > Incorporated some Changes to include things like runservice readme checkbox, > changing the default installation location etc.. > > > Diffs > ----- > > client/pom.xml 29fef4f > pom.xml 0b3b56e > scripts/installer/windows/ExitDialog.wxs PRE-CREATION > scripts/installer/windows/WixInstallerDialog.wxs 0282d8a > scripts/installer/windows/acs.wxs bf09afc > scripts/installer/windows/dependencies.wxs 987c561 > scripts/installer/windows/en-us.wxl 2f34575 > scripts/installer/windows/optionstheme_en-us.wxl c822929 > scripts/installer/windows/readme.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/23192/diff/ > > > Testing > ------- > > Tested on Windows 2012 Server > > > Thanks, > > Damodar Reddy Talakanti > >