Hey Koushik, No problem, will do if required.
The review doesn’t have a “ship it” state, so thats why i assumed it was not committed. Also a lot of folks adopted the common practice to put the commit id in a comment after committing a review. That makes it easier to trace. Cheers, Hugo On 3 jul. 2014, at 14:29, Koushik Das <koushik....@citrix.com> wrote: > > >> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote: >>> I'm not sure we can actually have a dependency on the mysql connector like >>> this because of it's GPL license. I'll check this and get back on this >>> before we can accept this patch. > > Hugo, I committed this patch (on master > ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this > comment from you. If there is going to be a license issue then please feel > free to revert. > > > - Koushik > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23192/#review47289 > ----------------------------------------------------------- > > > On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/23192/ >> ----------------------------------------------------------- >> >> (Updated July 3, 2014, 11:58 a.m.) >> >> >> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo >> Trippaers. >> >> >> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 >> >> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 >> >> >> Repository: cloudstack-git >> >> >> Description >> ------- >> >> Incorporated some Changes to include things like runservice readme checkbox, >> changing the default installation location etc.. >> >> >> Diffs >> ----- >> >> client/pom.xml 29fef4f >> pom.xml 0b3b56e >> scripts/installer/windows/ExitDialog.wxs PRE-CREATION >> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a >> scripts/installer/windows/acs.wxs bf09afc >> scripts/installer/windows/dependencies.wxs 987c561 >> scripts/installer/windows/en-us.wxl 2f34575 >> scripts/installer/windows/optionstheme_en-us.wxl c822929 >> scripts/installer/windows/readme.txt PRE-CREATION >> >> Diff: https://reviews.apache.org/r/23192/diff/ >> >> >> Testing >> ------- >> >> Tested on Windows 2012 Server >> >> >> Thanks, >> >> Damodar Reddy Talakanti >> >> >
