----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48472 -----------------------------------------------------------
Ship it! - Kishan Kavala On July 22, 2014, 6:05 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23617/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:05 p.m.) > > > Review request for cloudstack, Kishan Kavala and Nitin Mehta. > > > Repository: cloudstack-git > > > Description > ------- > > Putting the create event into event bus for addNicToVirutalMachine command > explicitly as we can not use BaseAsyncCreateCommand.We can not extend this > with BaseAsyncCreateCmd due to the checks we do before creating the nic. > > > Diffs > ----- > > api/src/com/cloud/event/EventTypes.java 411f620 > server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef > > Diff: https://reviews.apache.org/r/23617/diff/ > > > Testing > ------- > > Tested against the following setup: > > 1. XenServer 6.2 > 2. Master Branch > > > Thanks, > > Damodar Reddy Talakanti > >
