> On Aug. 5, 2014, 2:27 p.m., Rajani Karuturi wrote:
> > According to the wiki 
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes%2C+using+Simulator
> >  I think the flag should be required_hardware=false

Required_hardware = false tells us that these test cases can run on simulator, 
but it does not tell us that these test cases should run only on simulator. 
These particular test cases must not run on any other hypervisor than simulator.

I had discussion on this with Santhosh. We need to update the wiki page for 
this.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24298/#review49576
-----------------------------------------------------------


On Aug. 5, 2014, 11:55 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24298/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 11:55 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The tests in test suites test_deploy_vm.py and test_vm_ha.py need to be run 
> serially, hence moved them to misc folder.
> Also tagged the tests as "required_hardware='simulator only'" which require 
> to be run only on simulator.
> 
> Moved the normal tests (for which above criteria don't apply) from 
> test_deploy_vm.py to test_vm_life_cycle.py in smoke folder.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py 29cdb96 
>   test/integration/smoke/test_vm_ha.py c7d1648 
>   test/integration/smoke/test_vm_life_cycle.py 1386830 
> 
> Diff: https://reviews.apache.org/r/24298/diff/
> 
> 
> Testing
> -------
> 
> Yes, tested test_vm_life_cycle.py with python command.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Reply via email to