> On Aug. 6, 2014, 6:49 p.m., Doug Clark wrote: > > test/integration/smoke/test_vm_life_cycle.py, line 253 > > <https://reviews.apache.org/r/24298/diff/4/?file=653693#file653693line253> > > > > What is the advantage of catching an exception only to immediately > > re-raise it? > > > > Will the stack trace for the original exception still appear in the > > logs? > > Santhosh Edukulla wrote: > Its not an issue though, uncaught exceptions cause script to exit, in > case of this, it can still continue with other tests. Gaurav, dump to log if > we want, but output can be caught to console and be viewed easily from > jenkins.
It's just tells us quickly that exception has occured in cleanup operation. Does not make a huge differnce. > On Aug. 6, 2014, 6:49 p.m., Doug Clark wrote: > > test/integration/smoke/misc/test_deploy_vm.py, line 257 > > <https://reviews.apache.org/r/24298/diff/4/?file=653689#file653689line257> > > > > In the previous comment an exception in tearDown resulted in an > > exception being raised - here we just output a debug to the logs - can we > > make this consistent? Yes, will raise exception here. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24298/#review49732 ----------------------------------------------------------- On Aug. 6, 2014, 6:03 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24298/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 6:03 p.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6873 > https://issues.apache.org/jira/browse/CLOUDSTACK-6873 > > > Repository: cloudstack-git > > > Description > ------- > > The tests in test suites test_deploy_vm.py and test_vm_ha.py need to be run > serially, hence moved them to misc folder. > Also tagged the tests as "required_hardware='simulator only'" which require > to be run only on simulator. > > Moved the normal tests (for which above criteria don't apply) from > test_deploy_vm.py to test_vm_life_cycle.py in smoke folder. > > > Diffs > ----- > > test/integration/smoke/misc/__init__.py PRE-CREATION > test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION > test/integration/smoke/misc/test_vm_ha.py PRE-CREATION > test/integration/smoke/test_deploy_vm.py 29cdb96 > test/integration/smoke/test_vm_ha.py c7d1648 > test/integration/smoke/test_vm_life_cycle.py 1386830 > > Diff: https://reviews.apache.org/r/24298/diff/ > > > Testing > ------- > > Yes, tested test_vm_life_cycle.py with python command. > > > Thanks, > > Gaurav Aradhye > >
