----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25065/ -----------------------------------------------------------
(Updated Aug. 28, 2014, 3:06 p.m.) Review request for cloudstack. Repository: cloudstack-git Description ------- pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... While it is probably good to have code that can dynamically add new lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in git now) there is no reason not to have the full static set of rules in the initial file. We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file... Diffs (updated) ----- core/test/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResourceTest.java aab1e72 plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java e133f7d server/src/com/cloud/network/element/CloudZonesNetworkElement.java 55cd5fa server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 33d7cd7 systemvm/patches/debian/config/opt/cloud/bin/vmdata.py a44c134 systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9 Diff: https://reviews.apache.org/r/25065/diff/ Testing ------- installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network Thanks, Fred Clift
