----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ -----------------------------------------------------------
(Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Changes ------- Updated diff to include 2 new unit tests Repository: cloudstack-git Description ------- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs (updated) ----- server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing (updated) ------- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
