> On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: > > Ship It! > > Rajani Karuturi wrote: > Thanks for adding tests. pushed to 4.5 > c919ff83d81528b89017b5f5731b2e46350e3dfa > will merge to master as well.
master 02ca6f2e5b7d8ffdc917ed09d8600c38e668ea17 - Rajani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 ----------------------------------------------------------- On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28049/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 4:23 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 > Validate Load Balancer rule with provider before commiting to DB and applying > new rule. > > > Diffs > ----- > > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 > server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/28049/diff/ > > > Testing > ------- > > Created 2 new unit tests that are located in > server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java > - Test to guarantee that validate is being called when updating LB rule > - Test to guarantee that it throws exception if LB rule is not validated by > provider > > Ran integration tests (smoke), all seems OK. > > > Thanks, > > Daniel Vega Simoes > >
