I have ignored this thread all morning to let it sink in. I do think we should encourage github PRs but abandonning reviewboard altogether seems like unnecessary to me. I am for removing all links to it.
so i think that comes down to +1 if... On Fri, Mar 27, 2015 at 12:44 PM, Gaurav Aradhye <gaurav.arad...@clogeny.com> wrote: > Agree. I even ported few patches from RB to PRs last week. I request all to > port old patches to Github PRs. > Also, learning to create pull requests takes very few minutes for those who > don't know how to. Adding the message with the proper link will greatly > help. > > Regards, > Gaurav > > On Fri, Mar 27, 2015 at 3:55 PM, Stephen Turner <stephen.tur...@citrix.com> > wrote: > >> +1 from me. All our process discussions over the (Northern Hemisphere) >> winter agreed that GitHub is the way forward. >> >> -- >> Stephen Turner >> >> >> -----Original Message----- >> From: Sebastien Goasguen [mailto:run...@gmail.com] >> Sent: 27 March 2015 08:52 >> To: dev@cloudstack.apache.org >> Subject: [DISCUSS] Stop using Review Board >> >> Hi everyone, >> >> Since GitHub pull requests have been enabled for cloudstack, we have >> closed 127 commits. >> >> I believe this is a nicer interface, one that folks are used to when >> contributing to other open source projects. >> >> In the meantime, we still have 73 open reviews on Review Board >> >> https://reviews.apache.org/ >> >> * I propose that we stop using RB all together, and remove any links to it >> from our website and README. >> >> A few of us have tried to close some of the reviews by pinging the authors >> already. >> >> * My second proposition is that we write a comment in all reviews: >> >> “Thanks for the patch, the cloudstack community has decided to stop using >> Review Board in favor of github pull request. >> You can see <link> to learn how to submit a pull request to cloudstack. >> Could you move your patch to a PR ? >> Without response from you we will close this review within 7 days. >> " >> >> There is good contribution guidelines in our docs README: >> https://github.com/apache/cloudstack-docs >> >> -Sebastien >> -- Daan
