Cool, thank you for the update! Will check out this in the morning. -----Original Message----- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, April 17, 2015 2:10 AM To: Funs Kessen Cc: Raja Pullela; dev@cloudstack.apache.org Subject: Re: OVM3 test failures
Funs, so you were not jumping a canon. The problem seems to me to be in the jenkins job in context of the marvin module. The tests from ovm3 themselves do pass. I did some tinkering with jenkins.bac.o and wil keep at it to get the red removed from the report page. I saw similar problems in jenkins.bac.o and am addressing those now. I will do the builds.a.o job next. On Thu, Apr 16, 2015 at 3:08 PM, Funs Kessen <f...@barred.org> wrote: > Daan, > > I can confirm that a fresh checkout of master and a build of marvin > after the apidoc works for me too. > > Cheers, > > Funs > >> On 16 Apr 2015, at 21:46, Funs Kessen <f...@barred.org> wrote: >> >> Daan, >> >> I did the same, but noticed it’s the cloudstack-marvin plugin, so am >> doing it again to figure out what’s going on there to see if I didn’t jump >> the gun with my comment. >> >> Cheers, >> >> Funs >> >>> On 16 Apr 2015, at 21:35, Daan Hoogland <daan.hoogl...@gmail.com> wrote: >>> >>> Funs,Raja, >>> >>> I did some more investigation. The issue has no relation to the >>> change mentioned by e indeed but neither to the latest commits. It >>> runs on my laptop (TM) so I suspect a problem on the jenkins slave >>> or an false assumption about the slaves in the tests. We'll need to >>> investigate further. I look at other marvin jobs. At first glance >>> they all seem to feel. (4.4, 4.5 etc.) >>> >>> On Thu, Apr 16, 2015 at 1:59 PM, Funs Kessen <f...@barred.org> wrote: >>>> Hi Raja, >>>> >>>> It seems there is no relation between what Daan was talking about and this >>>> problem as far as I can see. >>>> >>>> If you revert your last commit I suspect that everything is ok, so we need >>>> to figure out what your commit triggers that causes it to fail I guess as >>>> prior to that stuff seemed to work (tm). >>>> >>>> Cheers >>>> >>>> Funs >>>> >>>> PS: Are you on Cloudstack days in Austin per chance, then I could help you >>>> figuring out what’s going on. >>>> >>>>> On 16 Apr 2015, at 20:38, Raja Pullela <raja.pull...@citrix.com> wrote: >>>>> >>>>> the builds are failing due to ovm3 audit failures. >>>>> https://builds.apache.org/job/cloudstack-marvin/1723/console >>>>> >>>>> Daan, not sure if the change you were planning to do will address this >>>>> issue? >>>>> >>>>> Raj >>>>> -----Original Message----- >>>>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] >>>>> Sent: Friday, March 27, 2015 7:47 PM >>>>> To: Roger Crerie >>>>> Cc: dev@cloudstack.apache.org; Funs Kessen >>>>> Subject: Re: OVM3 test failures >>>>> >>>>> Shame on me, oh the public humiliation. will fix and submit, >>>>> thanks >>>>> >>>>> On Fri, Mar 27, 2015 at 3:07 PM, Roger Crerie <roger.cre...@hds.com> >>>>> wrote: >>>>>> Tests passed after I fixed the audit failures. Good on you :). >>>>>> >>>>>> Roger >>>>>> >>>>>> -----Original Message----- >>>>>> From: Roger Crerie [mailto:roger.cre...@hds.com] >>>>>> Sent: Friday, March 27, 2015 9:51 AM >>>>>> To: Daan Hoogland >>>>>> Cc: Funs Kessen; dev >>>>>> Subject: RE: OVM3 test failures >>>>>> >>>>>> I'm getting audit failures now. See attached text file. I'll fix them >>>>>> in code and run again but wanted to alert you to this. >>>>>> >>>>>> Roger >>>>>> >>>>>> -----Original Message----- >>>>>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] >>>>>> Sent: Friday, March 27, 2015 9:48 AM >>>>>> To: Roger Crerie >>>>>> Cc: Funs Kessen; dev >>>>>> Subject: Re: OVM3 test failures >>>>>> >>>>>> You should be able to do 'git pull' in your working dir, from the shell. >>>>>> >>>>>> On Fri, Mar 27, 2015 at 2:38 PM, Roger Crerie <roger.cre...@hds.com> >>>>>> wrote: >>>>>>> Having never pulled anything from cloudstack but the master how would I >>>>>>> go about getting this fix? >>>>>>> >>>>>>> Roger >>>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Funs Kessen [mailto:fozzielumpk...@gmail.com] On Behalf Of >>>>>>> Funs Kessen >>>>>>> Sent: Friday, March 27, 2015 7:21 AM >>>>>>> To: Daan Hoogland >>>>>>> Cc: Roger Crerie; dev >>>>>>> Subject: Re: OVM3 test failures >>>>>>> >>>>>>> Nah you are smart enough, it’s just that I was lazy and did a search >>>>>>> and replace and then noticed I broke something and fixed it with >>>>>>> another commit. >>>>>>> >>>>>>> thanks! >>>>>>> >>>>>>>> On 27 Mar 2015, at 12:12, Daan Hoogland <daan.hoogl...@gmail.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>> /me not being smart enough to use pull requests. >>>>>>>> >>>>>>>> I am pulling it now. >>>>>>>> >>>>>>>> On Fri, Mar 27, 2015 at 12:04 PM, Funs Kessen <f...@barred.org> wrote: >>>>>>>>> Hi Daan, >>>>>>>>> >>>>>>>>>> On 27 Mar 2015, at 11:58, Daan Hoogland <daan.hoogl...@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Funs, I commented on it, I think it has a typo in it. >>>>>>>>>> Roger, can you apply that patch and test (after looking at my >>>>>>>>>> comment)? >>>>>>>>> >>>>>>>>> I replied to you, that’s why the pull request contains two >>>>>>>>> commit IDs ;) >>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Mar 27, 2015 at 11:33 AM, Funs Kessen <f...@barred.org> >>>>>>>>>> wrote: >>>>>>>>>>> Hi Daan, >>>>>>>>>>> >>>>>>>>>>> Had a fix ready yesterday, but after having slept on it, I crushed >>>>>>>>>>> the fix as it was wrong. I’ve fixed it by setting the separator >>>>>>>>>>> hard, and not to File.separator. >>>>>>>>>>> >>>>>>>>>>> The logic behind is that the Agent runs on Linux and not on Windows >>>>>>>>>>> so using File.separator will just break things instead of making it >>>>>>>>>>> work, as the code should not be platform independent but >>>>>>>>>>> specifically for the Agent. >>>>>>>>>>> >>>>>>>>>>> I’ve got pull request #133 open which should resolve the issues on >>>>>>>>>>> Windows. >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> >>>>>>>>>>> Funs >>>>>>>>>>> >>>>>>>>>>>> On 26 Mar 2015, at 21:53, Funs Kessen <f...@barred.org> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 26 Mar 2015, at 21:41, Daan Hoogland <daan.hoogl...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Mar 26, 2015 at 9:35 PM, Funs Kessen <f...@barred.org> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> Hi Roger/Daan, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Sorry for coming late to the party, and my apologies in advance! >>>>>>>>>>>>> >>>>>>>>>>>>> that's alright, i learned something about cs;) >>>>>>>>>>>>> >>>>>>>>>>>> Ditto!! :) >>>>>>>>>>>> >>>>>>>>>>>>> ... >>>>>>>>>>>>>> The second part of the booboo is in the tests themselves >>>>>>>>>>>>>> actually as you’ve noticed, so I’ll have to place the >>>>>>>>>>>>>> File.seperator there too in XenTest.java. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks for reaching out! >>>>>>>>>>>>>> >>>>>>>>>>>>>> @Daan: I can fix it in the ovm3rebase branch so you can pick it >>>>>>>>>>>>>> out ? >>>>>>>>>>>>> >>>>>>>>>>>>> yeah, that or send me a patch >>>>>>>>>>>>> >>>>>>>>>>>> I’ll get you a patch asap, want to make sure I don’t have >>>>>>>>>>>> to make two =) >>>>>>>>>>>> >>>>>>>>>>>>> Don't forget I added to the misery myself by adding >>>>>>>>>>>>> a4c23b170e4c94d4ed4783b19a051ad8f6c45328 >>>>>>>>>>>>> >>>>>>>>>>>> "My friend of misery" ? >>>>>>>>>>>> >>>>>>>>>>>> — >>>>>>>>>>>> =Funs >>>>>>>>>>> >>>>>>>>>>> — >>>>>>>>>>> =Funs >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Daan >>>>>>>>>> >>>>>>>>> >>>>>>>>> — >>>>>>>>> =Funs >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Daan >>>>>>>> >>>>>>> >>>>>>> — >>>>>>> =Funs >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Daan >>>>> >>>>> >>>>> >>>>> -- >>>>> Daan >>>> >>>> — >>>> =Funs >>>> >>> >>> >>> >>> -- >>> Daan >>> >> >> — >> =Funs >> > > — > =Funs > -- Daan
