Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-105935950
Hi @rsafonseca,
It's clear that this was quite some work to pull off, so first of all:
thanks! To be honest, I'm not sure on how to test this properly and help you
getting this through. If you can give some pointers on how we can test this,
that would help. Otherwise maybe others can test it.
The contents of the PR also changed a bit over time. Is the description
still covering the changes? Great btw that some stuff ended up in separate PR
(that got merged).
More general, could you please squash your commits? There are many commits,
lots of merge ones and also some that were more work-in-progress than anything
useful.
Regards,
Remi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
