Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-106741425
Hi @remibergsma
First of all. thank you for your comment :)
I've been very busy these past couple of days, so i haven't gotten around
to do what you suggested, but i will take care of that over the weekend (squash
commits, clean description of fixes), I will also try to get a couple more
stuff in as separate pull requests and clean up a couple more things ;)
As for testing this, there is no other way to test this other than manually
since marvin doesn't even use tomcat for testing, altough the travis setup
scripts download an old version of tomcat into the hard disk the tests do
nothing with it :) That should also be cleaned up.
Another handy thing that's really missing in the tests is a test to
packaging! In the past weeks a few things got into master that completely broke
packaging.. although Rohit fixed most of that already, centos6 packaging is
still broken.
As a side note, master also still doesn't work in Centos 7.1 and Fedora
21.. that's all in here hehe ;)
If you guys would like, i can also alter the test scripts to use the same
tomcat that will be used in the actual product instead of jetty, which will
make for a test scenario closer to reality. This can be done in a way which
will easily allow switching between tomcat and jetty in the future :)
What do you think of that?
BR,
Rafael
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
