Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/158#discussion_r34343974
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -790,8 +790,13 @@ def createZones(self, zones):
self.createPrimaryStorages(zone.primaryStorages,
zoneId,
)
- enabled = getattr(zone, 'enabled', 'True')
- if enabled == 'True' or enabled is None:
+
+ #get the variable from config file whether to enable zone
or not
+ #If "enabled" tag is not found in config file, enable the
zone otherwise
+ #act as mentioned in the config file
+ enabled = str(getattr(zone, 'enabled', None))
+ enabled = enabled if enabled else 'true'
+ if enabled.lower() == 'true':
--- End diff --
should work but why not make a str('boolean') a real bool?
if enabled.lower == true:
enable = True
else:
enable = False
if enable:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
