-1 on dropping old upgrade code. I prefer skipping old upgrade paths during coverity scan instead of removing the code altogether. Even with multi-step upgrade, user will be forced to register system templates multiple times (once for every step). Agree with John regarding the need to establish a standard upgrade policy.
-----Original Message----- From: John Burwell [mailto:john.burw...@shapeblue.com] Sent: 20 July 2015 09:41 PM To: dev@cloudstack.apache.org Subject: Re: [PROPOSAL] drop old upgrade code Daan, While I see the desire to remove outstanding scan issues, doing it at the expense of a feature required by users is not acceptable to me. My first question is how many users are still running pre-4.x versions? In its current state, the commit message lacks an explanation of the reasoning for the change, and there is no documentation about the change. Until these basic bits of documentation are addressed, and we have a good feel for the user impact, I am -1 on this change. With this change, I think we should also establish a standard upgrade support policy (e.g. current minor release - x revisions). If a user falls far enough behind, they would be require to execute a multi-step upgrade in order to upgrade to latest. Whatever we decide, it should be clearly documented, and discussed on dev@ and user@. I am happy to pose these questions on user@ to get a feel for the potential impact of this change and input on the desired upgrade policy. Thanks, -John --- John Burwell (@john_burwell) VP of Software Engineering, ShapeBlue (571) 403-2411 | +44 20 3603 0542 http://www.shapeblue.com Please join us at CloudStack Collab EU — http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe > On Jul 20, 2015, at 10:27 AM, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > > in anticipation of loads of +1's I made a new PR (at [2]) > > On Mon, Jul 20, 2015 at 2:29 PM, Wido den Hollander <w...@widodh.nl> wrote: >> >> >> On 20-07-15 13:48, Daan Hoogland wrote: >>> LS, >>> >>> In coverity the only remaining high impact issues are concerned with >>> upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4 >>> upgrades. >>> >>> I addressed the file Upgrade218to22.java in a PR [1] and I move that >>> we don't pull it but instead drop the file altogether together with >>> all upgrade code dating prior to 4.0.0. anybody on older versions >>> can still upgrade to any version between 4.0 and 4.5 and move on >>> from there. >>> >>> My objective is to have no high impact issues remaining so we >>> clearly see when we are digressing beit by hand or in an automated way. >>> >>> +1? >>> >> >> +1 I don't see a reason to keep supporting these ancient upgrade paths. >> >> Wido >> >>> [1] https://github.com/apache/cloudstack/pull/603 > > [2] https://github.com/apache/cloudstack/pull/608 > > > -- > Daan Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
