-1 to dropping pre-4.x upgrade code. If possible we should suppress the old upgrade files from coverity scan.
Reasons: There may be users on pre-4.x versions. Removing a functionality should be associated with proper documentation and an advanced notification in some prior releases. This is similar to the way some API is deprecated and then eventually removed. -Koushik -----Original Message----- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, 20 July 2015 17:19 To: dev Subject: [PROPOSAL] drop old upgrade code LS, In coverity the only remaining high impact issues are concerned with upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4 upgrades. I addressed the file Upgrade218to22.java in a PR [1] and I move that we don't pull it but instead drop the file altogether together with all upgrade code dating prior to 4.0.0. anybody on older versions can still upgrade to any version between 4.0 and 4.5 and move on from there. My objective is to have no high impact issues remaining so we clearly see when we are digressing beit by hand or in an automated way. +1? [1] https://github.com/apache/cloudstack/pull/603 -- Daan
