Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35191354 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -57,17 +57,22 @@ private LdapContextFactory _ldapContextFactory; @Inject - private LdapUserManager _ldapUserManager; + private LdapConfiguration _ldapConfiguration; + + @Inject LdapUserManagerFactory _ldapUserManagerFactory; + public LdapManagerImpl() { super(); } - public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManager ldapUserManager) { + public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManagerFactory ldapUserManagerFactory, + final LdapConfiguration ldapConfiguration) { --- End diff -- It was initially done that way. We could inject as well. I did that in the new class. -----Original Message----- From: "Daan Hoogland" <notificati...@github.com> Sent: â22-â07-â2015 13:18 To: "apache/cloudstack" <cloudst...@noreply.github.com> Cc: "Rajani Karuturi" <rajanikarut...@gmail.com> Subject: Re: [cloudstack] CLOUDSTACK-8596 ability to query nested groups forMicrosoft AD (#609) In plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java: > > public LdapManagerImpl() { > super(); > } > > - public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManager ldapUserManager) { > + public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManagerFactory ldapUserManagerFactory, > + final LdapConfiguration ldapConfiguration) { And why not use injection for that as well? Is this a groovy thing? â Reply to this email directly or view it on GitHub.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---