Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/609#discussion_r35291227
  
    --- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
 ---
    @@ -36,6 +36,8 @@
     
         private static final ConfigKey<Integer> ldapPageSize = new 
ConfigKey<Integer>(Integer.class, "ldap.request.page.size", "Advanced", "1000",
                                                                                
    "page size sent to ldap server on each request to get user", true, 
ConfigKey.Scope.Global, 1);
    +    private static final ConfigKey<String> ldapProvider = new 
ConfigKey<String>(String.class, "ldap.provider", "Advanced", "openldap", "ldap 
provider ex:openldap, microsoftad",
    +                                                                           
     true, ConfigKey.Scope.Global, null);
    --- End diff --
    
    As part of this change please move all LDAP related config to use the 
ConfigKey/Configurable mechanism of publishing them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to