Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36833745
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
<copy
todir="${basedir}/target/generated-webapp/WEB-INF/classes/scripts">
<fileset dir="${basedir}/../scripts"/>
</copy>
+ <copy
todir="${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js">
--- End diff --
FS
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy
has details regarding console proxy workflow which is present in description.
In developer setup these files are always present so adding unit test for
certain (which will always pass) thing doesn't make sense to me. In my opinion
unit test are meant to test corner cases or some uncertainty.
I will try to improve description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
