Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36839282
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
<copy
todir="${basedir}/target/generated-webapp/WEB-INF/classes/scripts">
<fileset dir="${basedir}/../scripts"/>
</copy>
+ <copy
todir="${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js">
--- End diff --
Thanks for the FS link, it was helpful. Regarding the unit test, i would
disagree to say that they are meant to test corner cases. Not sure, what it
doesnt make sense to you. In general, unit test purpose is not what you meant,
in this commit, if we see we modified near to 28 code files, added new classes
and code, it makes sense to have unit tests for the added code. It will help
to test the code units and individual functional blocks during build, these
areas not always are touched by functional tests. It adds to the coverage, make
sure code modified down the lane adheres to the contract through failures in
tests etc. Its appreciated, if we can have few unit tests added to this, right
now they are zero tests for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
