Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-138651375
If you tested, that is ok to me. I had not had the opportunity to build and
test the ACS with that code in my environment. I just analyzed the code and
checked how the SQL was generated, and executed that SQL using Squirrel SQL
client. Perhaps as you pointed out that the select I tested did not work
because of SQL client I used.
The code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
