Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/775#issuecomment-140824594
  
    @DaanHoogland and @nitin-maharana, I was thinking about this PR. I do not 
think that it is easy to write unit test for this.
    
    First the method is huge (around 100 lines), and second it is a method that 
performs database access (it builds "queries" to retrive data).  Maybe, if you 
extract the creation of sc1 from lines 356 – 357 and then test the search 
criteria that was created. But still, that might not seem a pretty test case.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to