Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153517886
I liked Edison's approach to reviewing storage plug-in code: Since our
storage plug-ins don't really run in "sandboxes," his approach was to mainly
examine the code to try to make sure it wasn't inadvertently doing something
bad to the data in the DB. For example, storage plug-ins have direct access to
the DB via DAO objects and can accidentally delete data that doesn't belong to
them.
Aside from those kinds of actions, Edison didn't encourage spending too
much time trying to verify the correctness of storage plug-in code (that was an
exercise left to the vendor).
Personally, though, I'd like to get to the point where I can bring my
Marvin integration tests to the CloudStack repo and have them execute against
virtual hardware. At the time being, however, this is not an option.
I also like having the ability to run these integration tests against
different hypervisor types and versions, but am not yet confident I know how to
do this within CloudStack's integration-test environment (so I just do this in
house at SolidFire).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
