Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161027097
@rafaelweingartner I agree with you in general lines. In this case the test
had not just succeeded so far, it also started failing a lot since a few days.
So something has definitely changed. I had not looked at the implemetation of
the test to see the root cause yet but will have a look.
As for the important bit: The integration tests are maybe a misleading name
as I see them as functional enduser tests (for API users, not UI users). and
not integration tests. In that sense we don't care about the expunge thread but
we do want to see that VMs are expunged after a certain time. In fact the use
case you mention as an alternative is not that, an alternative but another
usecase that should also be tested.
Your solution sounds fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
