Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-174734613
@serg38, I did not know that, giving your explanation I rest my arguments ;)
@nvazquez, you changed the method âgetMountPointâ to receive a NFS
protocol version, that method uses the version in another method that is called
âmountâ, in which you added a conditional to check if the version != null,
then you add it to the mount command. I am ok with that code.
I only have a doubt, if the version may be required why arenât you using
it in most of the code? It seems that you mostly call the âgetMountPointâ
method as âmountService.getMountPoint(secondaryStorageUrl, null)â.
Actually, the only time I see you using the NFS protocol version is when
you use the âprepareSecondaryStorageStoreâ method. As @serg38 nicely
explained that there are vendors that do not support version negotiation,
wouldnât that be the case to always use the version that you already have in
hand?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
