Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1457#issuecomment-204624408
  
    @nvazquez,
    I find the “AlertManager” class terrible for that. Its name gives the 
idea of something that manages alerts and not clusters 
parameters/configurations. 
    
    To add that property, I was thinking about the 
“com.cloud.resource.ResourceManagerImpl.discoverCluster(AddClusterCmd)” 
method (lines 491 and 492 are already doing that for over-commitment factors), 
and then you could create a static entry at “CapacityManager” that seems to 
be the best option to hold such configurations.
    
    If you change the “discoverCluster”, you would still need a script to 
add that parameter to those clusters that the environment already has. You have 
to do that to enable the users to change those parameters and use that 
functionality through the web interface.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to