Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r60393439
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -206,4 +216,87 @@ public static void scpTo(String host, int port, String
user, File pemKeyFile, St
conn.close();
}
}
+
+ /**
+ * It gets a {@link Session} from the given {@link Connection}; then,
it waits
+ * {@value #WAITING_OPEN_SSH_SESSION} milliseconds before returning
the session, given a time to
+ * ensure that the connection is open before proceeding the execution.
+ *
+ * @param conn
--- End diff --
@GabrielBrascher this is the kind of javadoc I don't like. The header adds
an explanation but these tags don't add value to the names of the params
themselves. (just saying, no biggy)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
