Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62649582
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
---
@@ -638,7 +638,9 @@ protected Void
createTemplateAsyncCallBack(AsyncCallbackDispatcher<TemplateServi
}
private Map<String, TemplateProp> listTemplate(DataStore ssStore) {
- ListTemplateCommand cmd = new ListTemplateCommand(ssStore.getTO(),
imageStoreDetailsUtil.getNfsVersion(ssStore.getId()));
+ String nfsVersionParam =
imageStoreDetailsUtil.getNfsVersion(ssStore.getId());
+ Integer nfsVersion = (nfsVersionParam != null ?
Integer.valueOf(nfsVersionParam) : null);
--- End diff --
Please move the nfs version conversion from string to int to a separate
method, saw the same pattern at multiple places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
