Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63281291
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
---
@@ -61,11 +61,28 @@ public void setStorageManager(VmwareStorageManager
storageManager) {
this.storageManager = storageManager;
}
- public VmwareStorageSubsystemCommandHandler(StorageProcessor
processor, String nfsVersion) {
+ public VmwareStorageSubsystemCommandHandler(StorageProcessor
processor, Integer nfsVersion) {
super(processor);
this._nfsVersion = nfsVersion;
}
+ /**
+ * Reconfigure NFS version for storage operations
+ * @param nfsVersion NFS version to set
+ * @return true if NFS version coulb de configured, false in other case
--- End diff --
Should it be "_true if NFS version coul**d b**e configured, false in other
case_"? Thanks for the javadoc, good work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
