Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64323811
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long
routerId, final long guestNe
sc.setParameters("states", State.Stopped);
return listBy(sc);
}
+
+ @Override
+ public List<DomainRouterVO> listIncludingRemovedByVpcId(long vpcId) {
+ SearchCriteria<DomainRouterVO> sc = VpcSearch.create();
--- End diff --
QueryBuilder is a better abstraction to use for building queries it saves
the hardcoding of column names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
