Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1494#discussion_r64350508 --- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java --- @@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long routerId, final long guestNe sc.setParameters("states", State.Stopped); return listBy(sc); } + + @Override + public List<DomainRouterVO> listIncludingRemovedByVpcId(long vpcId) { + SearchCriteria<DomainRouterVO> sc = VpcSearch.create(); --- End diff -- These are not column names, these are the names that are given inside that VpcSearch object. This is how it's done in all DAOs :) ```java VpcSearch = createSearchBuilder(); VpcSearch.and("role", VpcSearch.entity().getRole(), Op.EQ); VpcSearch.and("vpcId", VpcSearch.entity().getVpcId(), Op.EQ); VpcSearch.done(); ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---