Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1640#discussion_r75147713
  
    --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
    @@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {
     
                     boolean fenced = false;
                     if (alive == null) {
    -                    s_logger.debug("Fencing off VM that we don't know the 
state of");
    +                    s_logger.debug("Fencing off VM " + vm + " that we 
don't know the state of");
    --- End diff --
    
    Please wrap in a isDebugEnabled check to avoid expensive string 
concatenation when DEBUG is off.  Also, should this message be a WARN instead 
of a DEBUG?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to