Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1605
@nvazquez,
Very nice proposal this one. I have only very small suggestions, which are
the following:
* The method âvideoCardConfigâ, would be better if called
âconfigureVideoCardâ, normally I treat methods as actions, and as such,
they normally start with a verb. This is cosmetics, but I think it helps to
follow the code.
* Method âmodifyVmVideoCardVRamSizeâ does not need that throws
Exception.
* Would you mind creating a test case for âmodifyVmVideoCardVRamSizeâ,
it is a very simple integration test case. It is pretty easy to do with mocks,
if you need any help, just send me an email.
* If you remove the âthrows exception from modifyVmVideoCardVRamSizeâ,
you can also remove from âsetNewVRamSizeVmVideoCardâ.
* Would you mind creating test cases for the method
âsetNewVRamSizeVmVideoCardâ?
* Method âvideoCardConfigâ, if you removed the âthrow Exceptionâ
from the above methods, you can remove the âCatch Exception from hereâ
* And also, what about test cases for the method âvideoCardConfigâ?
* What about changing the verb of âconfigSpecVideoCardNewVRamSizeâ
method to its complete form âconfigureâ?
* And finally, what about a test case for
âconfigSpecVideoCardNewVRamSizeâ?
@nvazquez great work, my suggestions are mostly aesthetics, but I think
they can help improve this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
