Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1605
@nv, I am sorry, my bad; last time I read the code, I overlooked the method
com.cloud.hypervisor.vmware.mo.VirtualMachineMO.getAllDeviceList(). Having said
that, how do you feel about extracting the try/catch block to
âgetAllDeviceListâ, then this method would not need to throw a checked
exception. It could re-throw a runtime exception such as the CloudRuntime.
From my understanding the test method âtestStartVm3dgpuEnabledâ is used
to test the method âconfigureVideoCardâ, right? What about changing that
method name to âtestConfigureVideoCardâ?
Moreover, do not you think that the method âconfigureVideoCardâ needs
at least two test cases? One that is already written, and the other to test the
condition in which the call
âvmSpec.getDetails().containsKey(VmDetailConstants.SVGA_VRAM_SIZE)â returns
false, and then the method âsetNewVRamSizeVmVideoCardâ is never called.
The same happens for the method âmodifyVmVideoCardVRamSizeâ, I think it
has another condition âvideoCard.getVideoRamSizeInKB().longValue() ==
svgaVmramSizeâ to be tested.
And finally, for the test method
âtestConfigureSpecVideoCardNewVRamSizeâ, what about using the
âMockito.InOrderâ to assure that the methods are being called in the proper
order. If someone changes that order of call in the future, that can affect the
method behavior.
I also have one small comment about the title of the PR and the commit
message. âImprove performanceâ seems a little too vague for a title. The
idea is very well explained on the PR, but the title does not reflect much.
What about, âimprove the performance of cloud-plugin-hypervisor-vmwareâ or
something like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
