Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r76550534
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse,
@BeanParam DeploymentPlan plan, E
boolean stop(String caller) throws ResourceUnavailableException,
CloudException;
/**
+ * Stop the virtual machine, optionally force
+ *
+ */
+ boolean stop(String caller, boolean forced) throws
ResourceUnavailableException, CloudException;
--- End diff --
@nathanejohnson I wasn't thinking to change any of the existing code. I am
just interested in avoiding incurring any more flag argument technical debt.
In terms of testing, this change is not hypervisor specific. Therefore, a
test case that utilizes the simulator might be a more fruitful path. @rhtyd
may have some thoughts as to how you could accomplish it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
