Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Hi @rafaelweingartner! Thanks a lot for your review! As usual, your
comments are really valuable.
I agree with you on the points you've mentioned and I've refactored the PR
based on them, mostly on the unit tests for the new methods which I have missed
out.
About, `test_vm_snapshots.py` it passed successfully, please let me know if
it is needed to post results and I'll rebase 4.9 branch and re ran the test.
Thanks again for taking the time to review the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
