Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105488183
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId) {
txn.commit();
}
+ @Override
+ public List<StoragePoolTagVO> searchByIds(Long... stIds) {
+ String batchCfg = _configDao.getValue("detail.batch.query.size");
--- End diff --
@nvazquez what about extracting lines 95-97 to a method?
Then, we can have test cases and some doc for it. Especially for that 2000
magic number there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
