Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105797159
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -409,15 +460,13 @@ public StoragePoolVO persist(StoragePoolVO pool,
Map<String, String> details) {
sc.and(sc.entity().getScope(), Op.EQ, ScopeType.ZONE);
return sc.list();
} else {
- Map<String, String> details = tagsToDetails(tags);
-
- StringBuilder sql = new
StringBuilder(ZoneWideDetailsSqlPrefix);
+ StringBuilder sql = new StringBuilder(ZoneWideTagsSqlPrefix);
--- End diff --
Thanks for pointing this out, I had missed it out. Created methods
`getSqlPreparedStatement` and `searchStoragePoolsPreparedStatement` which are
called from many methods and allow storage pool retrieval
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
