Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1278
Hi @rafaelweingartner @anshul1886 @GabrielBrascher,
I've read this PR's comments several times and I think I could understand
@anshul1886's point. Please correct me if I'm wrong. The execution of
`getCallingAccount()` is setting the context with the proper account, and I
think that's fine, as next methods will use it (e.g. `orchestrateStart` in
`VirtualMachineManagerImpl` lines 829-831).
I also agree with @rafaelweingartner and @GabrielBrascher that even though
the context is being set, variables `user` and `caller` on `start` method
(defined on line 266) are not being used. @anshul1886, if no validations are
required and the context is already set, don't you think that those unused
parameters can be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
