+1

On Fri, 14 Feb 2020 at 13:18, Wido den Hollander <w...@widodh.nl> wrote:

>
>
> On 2/14/20 1:03 PM, Daan Hoogland wrote:
> > devs, I thought I had already sent a mail about this but i cannot find
> it.
> > I'm sure i had mentioned it somewhere (probably on github).
> > this is a follow up on [1] and hopefully you'll agree, a slight
> improvement.
> >
> > here it comes:
> >
> > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in
> the
> > title. This title stands the chance of being merged once we agree the PR
> is
> > ready for merge. It also clutters the title.
> >
> > Github has introduced a nice feature a while ago; draft PR. When
> creating a
> > PR you can opt not to open it for merge but as draft. Choose a button
> left
> > of the "Create pull request" button, marked "Create draft PR". It will
> be a
> > full PR with all CI and discussion possibilities open. The only
> difference
> > is the merge button being disabled. One will than have to make/mark it
> > "ready for merge" before it *can* be merged.
> >
>
> That sounds like a good idea! Would be a +1 from me :-)
>
> Wido
>
> > [1]
> >
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> > please shoot any comments you may have back at me,
> > thanks
> >
>


-- 

Andrija Panić

Reply via email to